Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add id when registering services to consul #1802

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

shiling02404
Copy link
Contributor

Signed-off-by: wisdom [email protected]

Description

In the absence of an id, different instances of the same service registered to consul will be overwritten.
So, new id is added to distinguish them.

Issue reference

#1513
#1199

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@shiling02404 shiling02404 requested review from a team as code owners June 21, 2022 03:00
@ItalyPaleAle
Copy link
Contributor

Does this impact name resolution in any way? Does this change what responses consul gets?

@shiling02404
Copy link
Contributor Author

Does this impact name resolution in any way? Does this change what responses consul gets?

No impact on name resolution,
Does not change the response of the consul。

id:The ID of the service. This will default to -name if not set.
https://www.consul.io/commands/services/register#id

@ItalyPaleAle
Copy link
Contributor

Approved for me. Thanks for this PR :)

A maintainer can merge it.

@berndverst berndverst added this to the v1.8 milestone Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1802 (696dc8f) into master (4322a22) will increase coverage by 0.29%.
The diff coverage is 23.22%.

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
+ Coverage   36.59%   36.89%   +0.29%     
==========================================
  Files         177      179       +2     
  Lines       16222    16265      +43     
==========================================
+ Hits         5937     6001      +64     
+ Misses       9617     9570      -47     
- Partials      668      694      +26     
Impacted Files Coverage Δ
authentication/azure/auth.go 38.12% <0.00%> (ø)
...indings/azure/servicebusqueues/servicebusqueues.go 2.02% <0.00%> (-8.67%) ⬇️
bindings/redis/redis.go 18.18% <0.00%> (-2.88%) ⬇️
bindings/zeebe/client.go 27.27% <ø> (ø)
bindings/zeebe/command/command.go 87.50% <ø> (ø)
bindings/zeebe/command/complete_job.go 64.70% <ø> (ø)
bindings/zeebe/command/create_instance.go 77.77% <ø> (ø)
bindings/zeebe/command/update_job_retries.go 71.42% <ø> (ø)
bindings/zeebe/jobworker/jobworker.go 11.34% <ø> (ø)
internal/component/kafka/consumer.go 0.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf6111...696dc8f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants