Add APP_PROTOCOL env var for app #1318
Conversation
Signed-off-by: ItalyPaleAle <[email protected]>
| case "": | ||
| return string("http") | ||
| default: | ||
| return "" |
There was a problem hiding this comment.
Should we error out if appPort is invalid?
There was a problem hiding this comment.
We don't normally error in the injector, because that causes the injection to fail and it's hard to debug. I'd let daprd handle the invalid value on startup
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
+ Coverage 26.81% 27.55% +0.74%
==========================================
Files 39 39
Lines 3882 3912 +30
==========================================
+ Hits 1041 1078 +37
+ Misses 2767 2757 -10
- Partials 74 77 +3
|
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
Can this be re-opened please? Also, is there something blocking this PR from being merged? @dapr/maintainers-cli @dapr/approvers-cli |
This PR is the companion of dapr/dapr#6512 which makes the same change in the Dapr Injector.
It adds the
APP_PROTOCOLenv var for the app that is being started withdapr run. As explained in the PR in dapr/dapr, this is helpful for the app to know if it should start a server with HTTPS or H2C enabled.