Berlin changes #634
Berlin changes #634
Conversation
|
I also ran linters against the codebase in 7349aa6 so it would stop crashing my editor- once this is passing tests, if y'all hate the linter output, I will just refactor to take that out. |
|
@laudiacay super happy to see this PR, but the linter changes make this very hard to review, could you drop them from the PR please 🙏 |
|
Agree that dropping the linter changes make this a lot nicer. Some of the changes suggested by the linter are nice, like dropping redundant parens and simplifying expressions, but the I don't think we should adhere to its opinion on code alignment |
|
Would be happy to review the linter stuff in a seperate pr fwiw |
| rlpAccessList = BS.concat $ map (\accessEntry -> | ||
| rlpList [BS $ word160Bytes (accessAddress accessEntry), | ||
| BS $ rlpList $ map rlpWord256 $ accessStorageKeys accessEntry | ||
| ]) accessList |
There was a problem hiding this comment.
| rlpAccessList = BS.concat $ map (\accessEntry -> | |
| rlpList [BS $ word160Bytes (accessAddress accessEntry), | |
| BS $ rlpList $ map rlpWord256 $ accessStorageKeys accessEntry | |
| ]) accessList | |
| rlpAccessList = rlpList $ map (\accessEntry -> | |
| BS $ rlpList [BS $ word160Bytes (accessAddress accessEntry) | |
| , BS $ rlpList $ map rlpWord256 $ accessStorageKeys accessEntry] | |
| ) accessList |
There was a problem hiding this comment.
needs confirmation, but I think something like this would make more sense to get the rlp encoding right
There was a problem hiding this comment.
I think this is still wrong, I'm still getting a sender hash that doesn't exist in the prestate of the test. I'll mess with it and see what happens.
done, yeah, i'll PR them elsewhere later with something that removes warnings |
Draft PR for #619 ... Still in a bit of a messy state, but the bulk of the code's written, it just needs to be debugged & passing tests.
Berlin tests that I am starting to work against as of right now are here: https://github.com/ethereum/tests/releases/tag/8.0.3