-
Notifications
You must be signed in to change notification settings - Fork 4
Issues: dapperlabs/cryptokitties-bounty-2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author
Label
Projects
Milestones
Assignee
Sort
Issues list
QUESTION: What advantage does the escrow provide?
question
Further information is requested
#48
opened Nov 19, 2018 by
alxo44
Save gas by writing to storage once rather than twice in .updateOffer()
#46
opened Nov 19, 2018 by
ghost
Save gas by packing total and expiresAt into the same 256-bit word in the Offer struct
#45
opened Nov 19, 2018 by
ghost
Unnecessary fetches for pointers in three different functions when pointer already exists
#44
opened Nov 19, 2018 by
ghost
Inconsistent use of uint256 typecasts, either remove all or add all.
#42
opened Nov 19, 2018 by
ghost
lostAndFoundAddress: there is a (potentially very low) possibility that someone owns 0x0 public address
#38
opened Nov 18, 2018 by
pauliax
add a similar batchRemoveExpired() for a single address to save gas
#35
opened Nov 18, 2018 by
sunsetlover
Freeze permissions are less permissive than KittyCore, unable to freeze if CEO unavailable or CEO key lost
#32
opened Nov 17, 2018 by
ghost
major gas inefficiency in batchRemoveExpired due to state variable re-write at every iteration
#29
opened Nov 17, 2018 by
sunsetlover
Naming collision between global and local variables in cancelOffer and fulfillOffer
#26
opened Nov 17, 2018 by
ghost
Changing unsuccessfulFee should be coupled to minimumTotalValue
#24
opened Nov 17, 2018 by
freakitties
High-value kitty stealing: minOfferPrice is not communicated on-chain by user
#22
opened Nov 16, 2018 by
ghost
comment ambiguity about unit of totalCFOEarnings and totalLostAndFoundBalance
#20
opened Nov 16, 2018 by
sunsetlover
Payouts for Cancel in ReadMe's payout table can be stated more simply
#19
opened Nov 16, 2018 by
ghost
Previous Next
ProTip!
Follow long discussions with comments:>50.