Servlet niloc132 regression #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in the source xml file (grpc#8821)
e0dca93 broke the interop-testing script for unix because Gradle changed the scripts for GHSA-6j2p-252f-7mw8 The solution here looks weird, but we are inserting the replacement string into a single-quoted string, so we stop that string, start a double-quoted string to allow the variable replacement, and then resume the previous string.
* xds: fix a concurrency issue in CSDS ClientStatus responses Fixes an issue with ClientXdsClient.getSubscribedResourcesMetadata() executed out of shared synchronization context, and leading to: - each individual config dump containing outdated data when an xDS resource is updated during CsdsService preparing the response - config dumps for different services being out-of-sync with each other when any of the related xDS resources is updated during CsdsService preparing the response The fix replaces getSubscribedResourcesMetadata(ResourceType type) with atomic getSubscribedResourcesMetadataSnapshot() returning a snapshot of all resources for each type as they are at the moment of a CSDS request.
Previous versions of error prone were incompatible with Java 17 javac. In grpc-api, errorprone is now api dependency because it is on a public API. I was happy to see that Gradle failed the build without the dep change, although the error message wasn't super clear as to the cause. It seems that previously -PerrorProne=false did nothing. I'm guessing this is due to a behavior change of Gradle at some point. Swapping to using the project does build without errorProne, although the build fails with Javac complaining certain classes are unavailable. It's unclear why. It doesn't seem to be caused by the error-prone plugin. I've left it failing as a pre-existing issue. ClientCalls/ServerCalls had Deprecated removed from some methods because they were only deprecated in the internal class, not the API. And with Deprecated, InlineMeSuggester complained. I'm finding InlineMeSuggester to be overzealous, complaining about package-private methods. In time we may figure out how to use it better, or we may request changes to the checker in error-prone.
When client channel is shutting down, the RlsLoadBalancer is shutting down. However, the child loadbalancers of RlsLoadBalancer are not shut down. This is causing the issue b/209831670
Previously, only Windows had the plumbing to rename test results for the Kokoro result viewers to pretty-print. macos.cfg was the only CI that lacked a corresponding .sh, which maked unix.sh harder to reason about. Created macos.sh so that unix.sh is now just a helper script and will not be called directly by Kokoro. We now avoid "gradle clean" to avoid wiping results. Still clean compiler since we do re-run the build multiple times with varying platforms. Shouldn't be necessary, but "just in case" since I want this commit to be low risk. This improves Windows to produce detailed results even if the CI was successful.
`io.grpc.internal.testing.StatsTestUtils` in `grpc-testing` is only used internally by `grpc-interop-testing` and unit tests. The opencensus dependency does not need to be exposed to `grpc-interop-testing` maven artifact.
Also call onTransportReady() only if isReady() still holds by the time we get to a given Inbound. This dramatically reduces timeouts and improves throughput when flow control has kicked in. This approach is still not completely fair since each ongoing call might consume a different amount of window on its turn, but because of the way Outbound#writeMessageData() and BlockPool already work, everyone gets to send at least 16kb.
Oracle's Premier Support for Java 7 ended in July 2019. Per gRFC P5, dropping support for the only release. Android is able to desugar many Java 8 language features.
Be more explicit that "packagename" is the application package name.
…unused variable This fixes a soon-to-be compile error via ErrorProne. Alternatively, we could use assertThrows() instead of @test(expected = ...), but grpc doesn't yet require Java 8.
This reverts commit 3ad4d9b.
This was noticed because Mockito can't mock Random in Java 17, so it was replaced with actual Random. But when doing that change it exposed that negative numbers would cause the id to have a double '-'.
Implements least_request_experimental as defined by [A48](https://github.com/grpc/proposal/blob/master/A48-xds-least-request-lb-policy.md) These tests are mostly just a copy of RoundRobinLoadBalancerTest. The main difference is currently in the pickerLeastRequest test case. All other tests should be the same.
Implementation of the xDS Resolver section of the design http://go/grpc-rls-in-xds/view#heading=h.wkxepad0knu
git cherry is too conservative in determining backports. Showing all commits between the branch point and the release is more reliable.
Adopting the change in the [spec](https://github.com/grpc/proposal/blob/367ba33a0acfc411e2d2590887053e6d1e235ab1/A47-xds-federation.md#xds-api-changes): >Currently, for the ConfigSource fields in the LDS resource that points to the RDS resource and in the CDS resource that points to the EDS resource, gRPC requires the ConfigSource to have its ads field set. As part of supporting federation, gRPC will now also allow the ConfigSource to have its self field set. Both fields will have the same meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.