-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev.dap.ps is empty on IOS (develop 09.08.2019) #16
Comments
Yeah, this was likely because we were working on it at the moment you tried. I am fairly sure this is fixed now so am happy to close. If you feel differently, please re-open. |
@andytudhope |
Can you clear your cache? It's really strange that it would work everywhere but on a specific branch & device... |
Please check this again when you get a chance, would be interesting to see if it is still empty with anew contract instance etc. |
@andytudhope it is the same for me. |
@andytudhope same to me with iOS 13 Beta 4 (not sure if it matters). |
Yeah, it definitely matters @asemiankevich... I'm just not sure what to do about it 😅 Is there any way you can clear your cache in Status? It's weird that it would load everywhere but on a a particular device. Any chance you could get web console logs to see if there's a clue there as to what might be happening? |
@andytudhope I don't know how to clear cache in Status, in my case, I'm just creating new account. |
Ah, so it's the Status version... OK, any logs at all that you can get would be a good starting point... |
That's all I can get for IOS: |
Ha, it's hilarious trying to go through that... Anyway, here are some (maybe?) relevant parts:
|
I believe you only need to check logs for last 10 mins (I created new account, switched to Ropsten and accessed de.dap.ps) |
@flexsurfer are you able to replicate this on iOS. I have an Linux machine and am travelling, so not able to replicate it at all. We need to try and figure out what is causing this on the latest release so that we can fix it. The logs attached to this issue are less than useless, so any insight you could help provide would be super beneficial in terms of getting this fixed... |
i'm not sure if this is the reason, because i can see a list on ios even with these errors, how do you load a list of dapps ? do you get them from contract through web3 request? i can't see any logs in status |
@iamonuwa are you able to look at this in the next 2 days? If so, I will create a bounty here ASAP. @flexsurfer, yeah that is how we load them here and here |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 2 weeks from now. 1) iamonuwa has been approved to start work. This is a known issue on all platforms.
ETA 3 days Learn more on the Gitcoin Issue Details page. |
@andytudhope you'll have the fix tonight |
@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Hey @iamonuwa - what is happening here? Even a small update would help me understand the blocking issue better. |
Hello @iamonuwa? Testing, testing, 1 2 3? |
@andytudhope the code looks good, I can't reproduce this on any of the devices I've tested it on. @churik here are my thoughts
The app will load on a browser without web3 but cannot pull data from the contract. If you use a wrong contract, it will also fail. |
@iamonuwa which build are you using for testing? |
I can reproduce issue:
|
There's a possibility that Embark team might release |
but we still need to refactor a bit, show dapps list right after https://dap.ps/metadata/all call |
Available as always 😁🙏 |
ping @andytudhope |
That sounds like a separate issue though. |
Yeah, I think that it is, and I would still prefer to wait for Liquid Funding to be a thing for any kind of refactoring tbh. However, if you'd like to make a specific issue for that refactor @flexsurfer, I would be happy to put up a bounty. |
dap.ps is a crucial part of status app, because its the only way to discover dapps, currently it doesn't work, so no dapps, because it takes too long time to load on android and there is no list at all on ios, we can't ship v1 because of this blocker, to fix that we need to show list of dapps right after https://dap.ps/metadata/all call |
ok we can't show all dapps because we don't want to show not approved dapps , hm |
but in that case more dapps we'll have more time it will take to show dapps list, and later it might take like minutes to just show a list of dapps |
Signed-off-by: Jakub Sokołowski <[email protected]>
I just did a local build of |
It didn't occur to me that this is also blocking marketing. @flexsurfer since you're on v1 issues today, could you possibly prioritize this one? Sounds like latest Embark version might offer a simple fix? Though not clear to me if production ready. |
Looks like the version of Embark we were anticipating is |
Signed-off-by: Jakub Sokołowski <[email protected]>
Still not fixed. |
I've deployed build from #61 on https://dev.dap.ps/, please test it. |
kudos @jakubgs works on ios and in safari |
Brilliant. Also working for me. Thank you @jakubgs! |
can we deploy to dap.ps ? |
I have deployed the changes to https://prod.dap.ps/, seem to work: |
prod.dap.ps works great on iOS! Although dap.ps doesn't point there. |
|
Description
Type: Bug
Summary: no dapps on dev.dap.ps on latest nightly, but they are shown for release 0.13.0
Expected behavior
can see dapps list
Actual behavior
Reproduction
Additional Information
The text was updated successfully, but these errors were encountered: