-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dictator.sol #752
Merged
+328
−119
Merged
add dictator.sol #752
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
pragma solidity ^0.5.17; | ||
|
||
import "../controller/Avatar.sol"; | ||
import "../controller/Controller.sol"; | ||
import "@openzeppelin/upgrades/contracts/Initializable.sol"; | ||
import "@openzeppelin/contracts-ethereum-package/contracts/ownership/Ownable.sol"; | ||
|
||
/** | ||
* @title A scheme for register other scheme with full permission. | ||
*/ | ||
|
||
contract Dictator is Initializable, Ownable { | ||
|
||
Avatar public avatar; | ||
|
||
/** | ||
* @dev registerScheme | ||
* @param _scheme the scheme to register (with full permission) | ||
*/ | ||
function registerScheme(address _scheme) external onlyOwner { | ||
//register a scheme with full permission :) | ||
require(Controller(avatar.owner()).registerScheme(_scheme, 0x0000001f), "Fail to register scheme"); | ||
} | ||
|
||
/** | ||
* @dev _initialize | ||
* @param _avatar the scheme avatar | ||
* @param _owner the contract owner | ||
*/ | ||
function initialize(Avatar _avatar, address _owner) public initializer { | ||
require(address(_avatar) != address(0), "Scheme must have avatar"); | ||
Ownable.initialize(_owner); | ||
avatar = _avatar; | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not register the owner as admin right away in the initialize and then unregister self?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the initialize function is called as the process of instance the scheme before the scheme is registered .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right, so nevermind