Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new MetaMask "ethereum" provider #366

Merged
merged 4 commits into from
Oct 29, 2018
Merged

Use new MetaMask "ethereum" provider #366

merged 4 commits into from
Oct 29, 2018

Conversation

dkent600
Copy link
Contributor

@dkent600 dkent600 commented Oct 28, 2018 •
edited
Loading

Resolves: #365

  • uses the new MetaMask "ethereum" provider to instantiate web3, when available (see https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8)
  • adds a function Utils.getUserApprovalForAccounts for popping up the MM approve-account-sharing dialog, returning whether the user approved.
  • adds the ability for applications to be notified when the blockchain network id changes (via InitializeArcOptions.watchForNetworkChanges.
  • adds ability to force Utils.getWeb3 to re-instantiate the instance of web3 (such as when using a custom-provided web3 and the networkId has changed)

@dkent600 dkent600 self-assigned this Oct 28, 2018
@dkent600 dkent600 changed the title Handle new MetaMask "ethereum" provider Use new MetaMask "ethereum" provider Oct 28, 2018
@dkent600 dkent600 merged commit 5b3023b into master Oct 29, 2018
@dkent600 dkent600 deleted the MMConnectPrompt branch October 29, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibetsprague tibetsprague tibetsprague approved these changes

Assignees

@dkent600 dkent600

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkent600 @tibetsprague