fix: don't hard code fee recipient and withdrawals #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes a bit the way how
replayorhandles withdrawals and the fee recipient.Previous to this PR, the fee recipient is always hard coded to be the one of OP Stack chains, which is fine but I think it's better to take it directly from the block as we have this information inside the block. This also opens up the possibility to do some backtesting on eth mainnet (by tweaking its normal behaviour of course).
Same thing applies for withdrawals: we can take them directly from the block instead of hard coding them to empty.
@danyalprout