Pull in more fields from mods, drop milstein.csv #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After nearly 12 years, this drops the old
milstein.csvfile.The 2024 update has most of the same fields. The ones it's missing are "Source" and "Creator", which I can fill in from MODS. This gets some data updates and Unicode fixes. I've included a bunch of patches to keep the diff tiny, but I'll likely remove these in the future.
I also grabbed the date from MODS. This makes the diff bigger, but seems like a win. Data update: oldnyc/oldnyc.github.io@90a6669
There's one dropped photo, 708032f. This has been on the site for a long time in the wrong location (Manhattan, not Brooklyn). There's even a Facebook comment pointing this out! There was a data update on the NYPL side that makes this problem more clear and the location gets dropped. Hopefully I can pick it up again with #166.
This also includes some dead code elimination / refactoring.