Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support select by nearest point to mouse #917

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

squaregoldfish
Copy link
Contributor

This pull request implements a new selectMode option that allows switching the point selection mode between the closest X axis value (current behaviour) and the closest point to the mouse.

The option is activated by setting selectMode to either closest-x (the default current behaviour) or euclidian.

The changes that locked series, highlighted series and stacked graphs make to the selection behaviour have been carried across to the new euclidian mode to mimic existing behaviour as closely as possible. Tests have been added for all combinations of these options.

This work is related to issue #371. An additional change to getSelection() is required to handle multiple points with the same X axis value (#914), which is also included here.

There are two open questions:

  1. I have put the documentation for selectMode under Interactive Elements. If you want it in another section, let me know.
  2. I'm using findStackedPoint as it is currently written. However we now only use the series name, and none of the other information it returns. Should I cut down the method to only return a series name (and rename it to findStackedSeries), or leave it as it is in case it's useful in the future?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.298% when pulling 49aad3a on squaregoldfish:nearest-point-opt into 6611837 on danvk:master.

pawelzwronek added a commit to pawelzwronek/dygraphs that referenced this pull request Apr 14, 2018
Support select by nearest point to mouse danvk#917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants