-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ES6 modules #674
Merged
Use ES6 modules #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grest to see that dygraphs is moving forward. |
Running |
This was referenced Oct 26, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates dygraphs from its own ad-hoc dependency system to the new ES6 module system.
Highlights:
Dygraph
from a dozen different files.DEBUG
property to distinguish dev/prod builds.watch.sh
script.DEFAULT_ATTRS
gets moved into its own module.dygraph-combined.js
from source control (fixes Remove dygraphs-combined.js from source control #376)numberAxisLabelFormatter
) move out ofdygraph.js
and intodygraph-utils.js
. We need to shrinkdygraph.js
, it's huge.Fixes #453