Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - DictComp support #133

Closed

Conversation

Lkruitwagen
Copy link
Contributor

Description

What is this PR doing?

Adding support for DictComprehensions to EvalWithCompoundTypes. Addresses #57.

Pre-approval checklist (for submitter)

Please complete these steps

  • Passes tests
  • New tests for additional features or changed functionality
  • My name and contribution added to contributors list (or if I'd rather opt out, I've said so in the PR)

Copy link
Contributor

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danthedeckie Please review and merge this PR.

danthedeckie added a commit that referenced this pull request Oct 4, 2024
@danthedeckie
Copy link
Owner

Thanks so much @Lkruitwagen !

I've merged this via #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants