Don't misuse KeyError for the custom names function.
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.0.0 #126 +/- ##
==========================================
+ Coverage 99.20% 99.21% +0.01%
==========================================
Files 2 2
Lines 1128 1150 +22
==========================================
+ Hits 1119 1141 +22
Misses 9 9 ☔ View full report in Codecov by Sentry. |
kurtmckee
suggested changes
Jun 19, 2024
danthedeckie
force-pushed
the
better-names-exceptions
branch
from
219de17 to
d95f26e
Compare
Co-authored-by: Kurt McKee <[email protected]>
danthedeckie
force-pushed
the
better-names-exceptions
branch
from
d95f26e to
ee16fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #94
Makes
KeyErrorand stuff a bit more friendly for users using a customnameslookup.If their
namesfunction throws aKeyErrorunexpectedly, it was getting caught incorrectly.This expands the documentation & makes it so that people using a custom
namesresolver should deliberately only throw asimpleeval.NameNotDefined, other exceptions would be raised correctly.