DRY up the codebase

[danthareja]

Welcome new contributors!

In this experience, you are a doer. You take action first, and learn about the action afterwards. This design helps you get comfortable in the unknown, an entity that is omnipresent in the coding world. If you're feeling confused, that's ok. Read the instructions carefully, trust the process, and have fun!

To help guide you through the experience, there will be comment blocks (like the one your reading now) that explains just enough context before your next action.

Open Source and GitHub

An open source project is any code that can be freely used, changed, and shared by anyone. An open source project usually contains a license that declares specific terms of use. Open source projects are important because they help develop and spread great ideas and push technology forward.

GitHub is a website that hosts open source projects. A project on GitHub is called a repository (or repo), a folder that holds code. GitHub allows people to collaborate on a repo through features like issues and pull requests. By the end of this experience, you'll understand how to use these features to contribute your ideas to other projects.

Issues

Issues (like this one) allow people to track and discuss any task related to the project. Issues are not always problems with the code. They can also be feature requests or questions about how to use the code.

To help organize the project, issues can be tagged with one or more label. When you graduate from this project and are looking for more ways to contribute, look for projects with issues tagged with labels help wanted, good first issue, up-for-grabs, first-timers-only, or something similarly inviting.

Your turn

Now that you have a bit of context about the experience, continue reading the body of the issue to learn how to fix it.

---

We're off to an amazing start disrupting the calculator industry. Our beautiful contributors burned all of last week's midnight oil to release our first version and the initial reception has been unprecedented!

After a code review from some experts, we've learned that there's some unnecessary repetition in the codebase. Removing this repetition will make our codebase easier to maintain as we continue to grow into the world's best calculator company.

The team is burnt out from last week's push and needs your help! Before blowing half of our capital investment on a vacation in the Swiss Alps, the team managed to write some tests for this refactor, and left behind a roadmap to the next big release:

• Read the contributing guidelines
• Build the project locally
• Go to this line and change describe.skip to describe.only
• Run npm test
• Notice that the tests are failing
• Implement _check to make the tests pass
• Change the describe.only to describe so all the tests run
• Run npm test again
• Make sure that all the tests are passing
• Submit a pull request

---

This experience can be completed by multiple people. Below, you'll see references to this issue from various other contributors. You can ignore them.

[sourabh1031]

i am working on it and facing eslint problems since i am working on windows do i need to take care special care?

[danthareja]

@sourabh1031, are they the same problems you mentioned in your other issue danthareja/contribute-to-open-source-server#2? If so, did you try what I mentioned in the reply?

[sourabh1031]

Yes it got solved by your help thanks and now I must switch my work onto Unix based system isn't?

…

On Jan 14, 2018 9:32 AM, "Dan Thareja" ***@***.***> wrote: @sourabh1031 <https://github.com/sourabh1031>, are they the same problems you mentioned in your other issue danthareja/contribute-to-open- source-server#2 <danthareja/contribute-to-open-source-server#2>? If so, did you try what I mentioned in the reply? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYZ7Y0xcUkBTZhPexCCeW7PjDoWCAEsQks5tKXxmgaJpZM4QVZhc> .

[danthareja]

No need. As long as the styling issues are fixed, you can keep developing on Windows.

[fury2587]

Hello I am a newcomer, i have make a pull request as mentioned in the guideline but i don't know that you are able to see or not. please help me in that.

[JashanpreetSingh25]

For anyone having a " Expected linebreaks to be 'LF' but found 'CRLF' " error, this is just a related to inconsistent line endings in the code. It is just a Windows problem because Windows uses CRLF (Carriage Return + Line Feed) while Unix based system like Linux and MacOS uses LF (Line Feed). For Windows users, you can use WSL or use article to know how to fix it https://medium.com/bootdotdev/how-to-get-consistent-line-breaks-in-vs-code-lf-vs-crlf-e1583bf0f0b6. This was scary as a beginner but I just googled it, and done.