Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/resolve plain text #2371

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

BaloMueller
Copy link
Contributor

@BaloMueller BaloMueller commented Sep 9, 2024

Description

For Plaintext or Markdown files the proper way to resolve them is .get_media() instead of .export().

How Has This Been Tested?

Manual tests on my machine

Accepted Risk

None

Related Issue(s)

None yet

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 9, 2024

Someone is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@yuhongsun96 yuhongsun96 merged commit a4dcae5 into danswer-ai:main Sep 9, 2024
3 of 6 checks passed
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants