Connector deletion fix #2293
Merged
Connector deletion fix #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hagen-danswer
commented
Sep 2, 2024
| @@ -274,32 +276,30 @@ def test_connector_deletion_for_overlapping_connectors( | |||
| user_performing_action=admin_user, | |||
| ) | |||
|
|
|||
| # EVERYTHING BELOW HERE IS CURRENTLY BROKEN AND NEEDS TO BE FIXED SERVER SIDE | |||
|
|
|||
| # wait for deletion to finish | |||
There was a problem hiding this comment.
Enabled this test, now that it should work properly
| @@ -102,7 +102,7 @@ def delete_connector_credential_pair_batch( | |||
| UpdateRequest( | |||
| document_ids=[document_id], | |||
| access=access, | |||
There was a problem hiding this comment.
This is the fix. Basically, if the document didnt have any associated doc sets, it would not return any dict.
Setting it to None would just not update the doc set relationship at all in vespa.
So we can assume that if we are updating it and the document id isnt in the dict, that it has no sets related to it
| @@ -524,38 +524,54 @@ def fetch_document_sets_for_documents( | |||
| db_session: Session, | |||
| ) -> Sequence[tuple[str, list[str]]]: | |||
| """Gives back a list of (document_id, list[document_set_names]) tuples""" | |||
There was a problem hiding this comment.
Seperated out the stmt building and added a comment
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.