Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit Confluence Connector #2289

Merged
merged 10 commits into from
Sep 2, 2024
Merged

More explicit Confluence Connector #2289

merged 10 commits into from
Sep 2, 2024

Conversation

pablodanswer
Copy link
Contributor

@pablodanswer pablodanswer commented Sep 1, 2024

Description

Relevant docs update: danswer-ai/danswer-docs#114

Update Confluence connector to be more explicit

  • Split up 1 url -> wiki url, space name, page ID, and cloud (boolean)
  • Explicitly specify cloud vs. datacenter
Screenshot 2024-09-01 at 2 32 21 PM

How Has This Been Tested?

  • (With page ID) Create confluence connector on main -> upgrade and ensure indexing still works
  • Above but without page ID
  • Create confluence connector on this branch -> downgrade to main and ensure indexing still works
  • Above but without page ID

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 0:04am

@pablodanswer pablodanswer changed the title Migration Confluence connector to be more explicit More explicit Confluence Connector Sep 1, 2024
Copy link
Contributor

@Weves Weves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change the docs for confluence accordingly + link that PR in this PR 🙇

web/src/lib/connectors/connectors.ts Show resolved Hide resolved
@Weves
Copy link
Contributor

Weves commented Sep 1, 2024

Also, fyi @pablodanswer just updated the Github secrets to work with this PR

@Weves Weves merged commit c122be2 into main Sep 2, 2024
6 of 7 checks passed
@Weves Weves deleted the confluence branch September 2, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants