Detect GPU on startup for default multi-pass indexing value #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yuhongsun96
approved these changes
Aug 30, 2024
backend/danswer/main.py
Outdated
| @@ -341,6 +370,9 @@ async def lifespan(app: FastAPI) -> AsyncGenerator: | |||
|
|
|||
| translate_saved_search_settings(db_session) | |||
|
|
|||
| # update multipass indexing setting based on GPU availability | |||
| update_default_multipass_indexing(db_session) | |||
There was a problem hiding this comment.
I would place this later (after the embedding warm up setup) because that step has backoff and retries. Otherwise this call to check GPU could run before the model server is actually up
There was a problem hiding this comment.
note that the call later on checks for the inference server, not indexing
pablodanswer
force-pushed
the
model_startup_gpu
branch
from
c03a1c7
to
c1fbbfa
Compare
yuhongsun96
reviewed
Aug 31, 2024
| else: | ||
| model_server_url = f"{MODEL_SERVER_HOST}:{MODEL_SERVER_PORT}" | ||
|
|
||
| if "http" not in model_server_url: |
There was a problem hiding this comment.
No need to change but if this is now repeated functionality, we can pull it out into a function
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: