Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zendesk tickets #2192

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Zendesk tickets #2192

merged 5 commits into from
Sep 9, 2024

Conversation

jwjordan
Copy link
Contributor

Description

I updated the Zendesk connector to support a new required dropdown selection between "articles" and "tickets" with "articles" as the default for backward compatibility. If you already have a Zendesk connector set up, it will continue to work normally. If you set up a new one, you can choose "tickets" to have that connector sync all non-deleted Zendesk tickets. Therefore, you have the ability to create two separate Zendesk connectors using the same shared credentials, one for articles and one for tickets, which I felt would be useful in the creation of different Document Sets down the line (If you want both in the same Document Set, you can, but you can also easily separate knowledge of articles and tickets in the case where you want a Sales Assistant that only trains on articles, but a Support Assistant that trains on both articles and tickets).

How Has This Been Tested?

I tested this against my own Zendesk account by setting up the original Zendesk connection for articles, making code changes, and verifying that I can sync tickets properly. I then queried against known ticket contents to verify that Chat and Search work, and also verified that the citation links properly open the Agent view of the Zendesk ticket in a new browser tab. Finally I tested deletion of the new "tickets" connector and verified it had no effect on the pre-existing "articles" connector.

Accepted Risk

None that I'm aware of.

Related Issue(s)

I don't believe this feature request was recorded as an issue.

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Aug 21, 2024

@jwjordan is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@jwjordan
Copy link
Contributor Author

jwjordan commented Sep 9, 2024

@yuhongsun96 Any chance you'd be able to review this PR? Thanks!

@yuhongsun96
Copy link
Contributor

Hello! I will find time to look through it today! Thanks for your contribution!

@yuhongsun96 yuhongsun96 merged commit 4558351 into danswer-ai:main Sep 9, 2024
3 of 6 checks passed
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants