Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notion Connector - Block type external_object_instance_page is not supported via the API. #1761

Open
colachg opened this issue Jul 3, 2024 · 1 comment
Open

Notion Connector - Block type external_object_instance_page is not supported via the API. #1761

colachg opened this issue Jul 3, 2024 · 1 comment
Labels
Stale

Comments

@colachg
Copy link
Contributor

colachg commented Jul 3, 2024 •
edited
Loading

This is related to issue #1053 (fixed in #1059) and #1230 (fixed in #1231).

CleanShot 2024-07-03 at 09 48 54@2x

The connector consistently fails after indexing 7,552 documents, which is extremely frustrating.

CleanShot 2024-07-03 at 09 51 17@2x

I'm not sure, this is a good way to fix.

                if result_type == "external_object_instance_page":
                    logger.warning(f"Skipping 'external_object_instance_page' ('{result_block_id}') for page '{page_block_id}': "
                                   f"Notion API does not currently support reading external blocks (as of 24/07/03) "
                                   f"(discussion: https://github.com/danswer-ai/danswer/issues/1761)")
                    continue

I believe people may encounter various types of block errors. Is there a universal method to catch all these errors? Currently investigating.
colachg added a commit to colachg/danswer that referenced this issue Jul 3, 2024
@colachg
chore: Skip reading external blocks in NotionConnector
8ed5687 
The commit skips reading 'external_object_instance_page' blocks in the NotionConnector due to the lack of support in the Notion API. This change is in response to the issue danswer-ai#1761.
@colachg colachg mentioned this issue Jul 3, 2024
Merged
yuhongsun96 pushed a commit that referenced this issue Sep 8, 2024
@colachg
Notion Connector to skip reading external blocks in NotionConnector
e20c825 
The commit skips reading 'external_object_instance_page' blocks in the NotionConnector due to the lack of support in the Notion API. This change is in response to the issue #1761.

Co-authored-by: Cola Chen <[email protected]>
rajivml pushed a commit to UiPath/danswer that referenced this issue Oct 2, 2024
@colachg
Notion Connector to skip reading external blocks in NotionConnector
b362e12 
The commit skips reading 'external_object_instance_page' blocks in the NotionConnector due to the lack of support in the Notion API. This change is in response to the issue danswer-ai#1761.

Co-authored-by: Cola Chen <[email protected]>
rajivml pushed a commit to UiPath/danswer that referenced this issue Oct 2, 2024
@colachg
Notion Connector to skip reading external blocks in NotionConnector
45a3a90 
The commit skips reading 'external_object_instance_page' blocks in the NotionConnector due to the lack of support in the Notion API. This change is in response to the issue danswer-ai#1761.

Co-authored-by: Cola Chen <[email protected]>
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colachg