Upgrade Redux and related packages #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
changed the title
kasperg
approved these changes
Nov 22, 2024
Redux Toolkit v2 the action type changed from `any` to unknown, to encourage users to write type guards that checks the action object. The `action` object in `extractServiceBaseUrls()` was not originally written with types in mind, so we will keep it as `any` for now. But it would be nice to introduce some type for this in the future.
JacobArrow
force-pushed
the
DDFBRA-212-upgrade-redux
branch
from
65dd104
to
dc5b217
Compare
To tighten the type safety for ´extractServiceBaseUrls´ we validate the incoming action against a type guard
JacobArrow
force-pushed
the
DDFBRA-212-upgrade-redux
branch
from
dc5b217
to
0c03b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue