DDFHER-77 - Allow age to be equal to the configured minimum age in patronAgeValid
#1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated age validation logic to ensure the calculated age can be equal to the configured minimum age. Previously, the check only allowed ages greater than the minimum, which led to invalid rejections for users whose age exactly matched the threshold.
kasperbirch1
changed the title
patronAgeValidpatronAgeValid
rasben
approved these changes
Oct 10, 2024
kasperbirch1
deleted the
DDFHER-77-invalid-ssn-when-creating-with-mit-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-77
Description
The issue was that users whose age exactly matched the configured minimum age were being rejected during validation. The logic previously checked if the user's age was strictly greater than the minimum age, which caused this issue.
This pull request updates the age validation to ensure that the calculated age is greater than or equal to the configured minimum age. This resolves the problem by allowing users who are exactly the minimum age to pass validation.
Test
https://varnish.pr-1639.dpl-cms.dplplat01.dpl.reload.dk/