Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFHER-123 - Update dynamic_entity_reference to "3.2.0" #1727

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Nov 6, 2024

Link to issue

https://reload.atlassian.net/browse/DDFHER-123

Description

This update includes patch 3405253, which renames the feild to Dynamic entity reference, making it more distinguishable from core entity reference field types that use the Reference label.

@kasperbirch1 kasperbirch1 changed the title Update dynamic_entity_reference to "3.2.0" DDFHER-123 - Update dynamic_entity_reference to "3.2.0" Nov 6, 2024
@kasperg
Copy link
Contributor

kasperg commented Nov 6, 2024

@kasperbirch1 What do you think about adding a Cypress test for this?

@kasperbirch1
Copy link
Contributor Author

@kasperbirch1 What do you think about adding a Cypress test for this?

Yes, I can do that, but is it okay to add it in the paragraphs test? The paragraph card_grid_manual uses dynamic_entity_reference.

@kasperg
Copy link
Contributor

kasperg commented Nov 6, 2024

👍 Let's do that.

@kasperg kasperg removed their assignment Nov 6, 2024
@kasperg
Copy link
Contributor

kasperg commented Nov 6, 2024

👍 This is good to merge.

This update includes patch `3405253`, which renames the feild to `Dynamic entity reference`, making it more distinguishable from core entity reference field types that use the "Reference" label.
@kasperbirch1 kasperbirch1 force-pushed the DDFHER-123-update-dynamic-entity-reference branch from a7040fc to 5c5cb36 Compare November 6, 2024 13:46
@kasperbirch1 kasperbirch1 merged commit 60b1b78 into develop Nov 6, 2024
19 checks passed
@kasperbirch1 kasperbirch1 deleted the DDFHER-123-update-dynamic-entity-reference branch November 6, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants