Skip to content

danparnella/rails_challenge_movie_theater

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

15 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Danny's Rails Coding Challenge - Movie Theater App

Getting Started

Running in Development

  • git clone [email protected]:danparnella/rails_challenge_movie_theater.git
  • cd rails_challenge_movie_theater
  • bundle install
  • ask Danny for secrets
  • rails db:create db:migrate db:seed
  • rails server
  • open localhost:3000

Thoughts while Completing

  • I compiled requirements, a link to a DB diagram, some future enhancements / issues and at least one thing I would do differently here: Thoughts Document

Development Workflow

Pull Requests

This repo contains a template for Pull Request (PR) descriptions to help you to give easy and consistent instructions and context to a Code Reviewer and QA Reviewer. More information on PR best practices for both Authors and Reviewers are included in the LPL Pull Request Guidelines.

Committing

Pull requests to the dev branch will trigger review apps in Heroku. The staging branch will auto-deploy to the staging environment on Heroku. The main branch can then be deployed to production after successful QA.

Testing

All Ruby/Rails unit tests must pass for a PR to be merged. They can be run locally with:

  • Ruby/Rails unit tests: bundle exec rspec

Linting

The project is set up to lint ruby, so its advised that you have this integrated in your editor. Currently, linting errors will not block a PR merge, but this may change in the future.

You can run these manually with:

  • Ruby: rubocop (if installed globally with gem install rubocop)

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published