🖌️ fix: ordered lists markers #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
5 tasks
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Oct 30, 2024
* fix ordered lists markers styling * cleanup * refactor: additional padding for 3-digit markers * Refactor CSS to remove extra spacing in lists --------- Co-authored-by: Thingersoft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally #4546
Removed
::markerpseudo-element csscontentdefinitions to let browser generate appropriates list item markers.Also gave a little more room for markers to show because of Webkit slightly different text positioning.
Closes #4120, #4472.
Change Type
Testing
Open LibreChat in Safari and prompt any model to return an ordered list with more than 9 items.
Check that markers with 2 or more digits are shown correctly.
Checklist