💬 fix: adjust regex in ModelService to recognize o1- models returned fr… #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om OpenAI-API query API query for OpenAI returns list of models. Their names are filtered using a regex. The regex did not yet account for model names starting with o1-
danny-avila
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
API query for OpenAI returns list of models. Their names are filtered using a regex. The regex did not yet account for model names starting with o1- - with this change, model names starting with "o1-" are also recognized and will be shown in UI.
closes #4339
Change Type
Please delete any irrelevant options.
Testing
performed
docker buildwith this change and tested manuallyChecklist
Please delete any irrelevant options.