Coverband#start kicks off background thread #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless running in rack server. In this case middleware kicks off on first request.
kbaum
force-pushed
the
background_thread_reporting_from_start
branch
from
20bffbe
to
42568ea
Compare
danmayer
approved these changes
Nov 13, 2018
|
Done!
…On Mon, Nov 12, 2018 at 10:23 PM Dan Mayer ***@***.***> wrote:
***@***.**** approved this pull request.
feel free to merge when ready.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF6EmpUDIBs3TYSehnAgPeu-66RfExBks5uujtAgaJpZM4Yao3b>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless running in rack server. In this case middleware kicks off on first request.
This PR is an addition to #138