Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the file argument to self.configure in lib/coverband.rb #100

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Using the file argument to self.configure in lib/coverband.rb #100

merged 2 commits into from
Jul 24, 2018

Conversation

ThomasOwens
Copy link
Contributor

This allows a caller of Coverband.configure to not only pass in a block or have a file in ./config/coverband.rb, but to put the configuration file anywhere they want and pass it in as an argument. If the argument is unused, then the existing behavior is preserved. This should make it easier to invoke an application that uses Coverband from any working directory.

@ThomasOwens ThomasOwens changed the title #99 Using the file argument to self.configure in lib/coverband.rb Using the file argument to self.configure in lib/coverband.rb Mar 5, 2018
@danmayer
Copy link
Owner

Thanks @ThomasOwens I have been behind on taking PRs are my other branch makes some major breaking changes, but I will incorporate this soon. The Alpha branch is just about ready to go, I updated the readme to match the new version... https://github.com/danmayer/coverband/tree/feature/via_coverage#installation

@danmayer
Copy link
Owner

OK @ThomasOwens a PR for Coverband 2.0! Alpha release running on prod for last 2 months. Let me know if there is any last minute feedback, if not I will release later tonight ;) Also, sharing thoughts Future 3.0 roadmap.

#107

after that I will come back to this PR

@danmayer danmayer merged commit 1d55084 into danmayer:master Jul 24, 2018
@danmayer
Copy link
Owner

OK, this is merged into the 2.0 line, on the master branch. I am going to handle some of the other PRs and get a 2.x.x out in a few days, which will include this work. Thanks @ThomasOwens

@danmayer
Copy link
Owner

danmayer commented Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants