Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12869: dumpfile: should say if function has a const/pure attribute #6566

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix #12869: dumpfile: should say if function has a const/pure attribute #6566

merged 1 commit into from
Jul 5, 2024

Conversation

swasti16
Copy link
Contributor

@swasti16 swasti16 commented Jul 2, 2024

No description provided.

@firewave
Copy link
Collaborator

firewave commented Jul 2, 2024

Before we add that should probably resolve the existing inaccuracies including #6383 and #6385 so it is consistently named properly across.

@chrchr-github
Copy link
Collaborator

I think this change is OK, since it doesn't involve the library, and isAttributeConst() is not ambiguous.

@danmar
Copy link
Owner

danmar commented Jul 5, 2024

I think this change is OK, since it doesn't involve the library, and isAttributeConst() is not ambiguous.

I agree

@danmar danmar merged commit 1275c77 into danmar:main Jul 5, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swasti16 @firewave @chrchr-github @danmar