-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for subplane scrolling #1951
Comments
I've written a unit test for both cases, and it's supposedly passing, but visual inspection suggests something to be off. I think we're still scrolling despite |
and in the normal scrolling case, the subplane scrolls up as expected (6 lines), but the rest only scrolls up 3 (we would expect 6 here, as well). what? |
i've whipped up a PoC around this, |
so according to internal state, the FIXED one ought be staying where it is, at line 67, whereas the nonFIXED one ought indeed be rising -- as we see happen. so what does this mean? it suggests to me that our internal logic is correct, but it's not being properly executed. when we scroll, we scroll everything visible up, which is good for things which ought have scrolled, but wrong for things which ought not have scrolled. pretty simple. that explains the weirdness we saw in the second unit test i added, though not the first. it also means testing for this will be difficult, since all internal logic shows the correct values, and the error is only visible on-screen, ugh. so...we've got our unit tests. and we now know what's up with this issue. let's create a new bug for it. |
the mysterious stepping has gone away with 3cb54de, which seems to have addressed all of these problems, pretty much. yay! |
We supposedly worked out subplane scrolling in #1883, but the evidence (a working
notcurses-info
no matter the launch point) was resolved by an entirely different technique. So I have my doubts. Let's add some unit tests for this. Ideally, I think we'd movedisplay_bitmap()
innotcurses_info
back to where it was, and exercise the subplane scrolling code.The text was updated successfully, but these errors were encountered: