fix go version in go.mod #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.22 breaks modules that declare go 1.0: golang/go#65528 This PR modifies the Go version in go.mod to 1.14 because module must run on Go version 1.14 or later, as documented in https://go.dev/doc/modules/gomod-ref
|
Merged, thanks for taking care of this! |
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Feb 13, 2024
- Maintain a fork of electron that is suitable for both building on riscv64 and cross-compiling from x86_64: https://github.com/riscv-forks/electron - Currently 28-x-y-riscv and main-riscv branches are buildable - Patch gofslock to solve an error because of go1.22, upstreamed: danjacques/gofslock#14 - Remove `-Wl,-z,pack-relative-relocs` from LDFLAGS because it's not supported on riscv. Drop this after felixonmars#3526 get merged and devtools-riscv64 gets updated on builders. - Other usual electron fixes.
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Feb 13, 2024
- Maintain a fork of electron that is suitable for both building on riscv64 and cross-compiling from x86_64: https://github.com/riscv-forks/electron - Currently 28-x-y-riscv and main-riscv branches are buildable - Patch gofslock to solve an error because of go1.22, upstreamed: danjacques/gofslock#14 - Remove `-Wl,-z,pack-relative-relocs` from LDFLAGS because it's not supported on riscv. Drop this after #3526 get merged and devtools-riscv64 gets updated on builders. - Other usual electron fixes.
hubot
pushed a commit
to google/skia
that referenced
this pull request
Feb 21, 2024
I had to update the version of fslock to pull in danjacques/gofslock#14 Change-Id: Ic244758ce5be2b15583dcfb95884eb48e9ea0cce Reviewed-on: https://skia-review.googlesource.com/c/skia/+/816617 Reviewed-by: Leandro Lovisolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 breaks modules that declare go 1.0: golang/go#65528
This PR modifies the Go version in go.mod to 1.14 because module must run on Go version 1.14 or later, as documented in https://go.dev/doc/modules/gomod-ref