-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cryptography module #3
Open
milahu
wants to merge
25
commits into
danilobellini:master
Choose a base branch
from
milahu:use-cryptography-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Pavanetti <[email protected]>
milahu
force-pushed
the
use-cryptography-module
branch
from
May 25, 2024 13:45
f23728b
to
cfecad9
Compare
milahu
force-pushed
the
use-cryptography-module
branch
2 times, most recently
from
May 25, 2024 14:50
a52dd0b
to
c127c28
Compare
milahu
force-pushed
the
use-cryptography-module
branch
from
May 25, 2024 15:36
14f1c7e
to
b21e5b1
Compare
milahu
force-pushed
the
use-cryptography-module
branch
3 times, most recently
from
May 25, 2024 16:51
b920f94
to
340aa86
Compare
milahu
force-pushed
the
use-cryptography-module
branch
from
May 26, 2024 16:30
340aa86
to
1e4588a
Compare
milahu
force-pushed
the
use-cryptography-module
branch
from
June 1, 2024 11:33
8298b7f
to
a3b7fcf
Compare
milahu
force-pushed
the
use-cryptography-module
branch
from
June 2, 2024 13:03
2a58949
to
3b3f635
Compare
milahu
force-pushed
the
use-cryptography-module
branch
2 times, most recently
from
June 2, 2024 19:19
ba3c01f
to
669b9a0
Compare
milahu
force-pushed
the
use-cryptography-module
branch
from
June 2, 2024 19:58
669b9a0
to
e5b05bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make aia 30x faster
before
downstream PR: pyload/pyload#4478
cache cadata by host regex
save memory and time
in this example,
target_name
is*.ucdn.to
so cadata is computed only for the first request with
www788.ucdn.to
and the cached value is used for
www123.UCDN.to
custom caching
the new method
cadata_and_host_regex_from_host
is useful to implement custom caching
without having to re-parse the leaf cert for the host regex
for example, pycurl loads cacert from a file
so the certs for
*.ucdn.to
can be stored incache/certs/_.ucdn.to.crt
and
host_regex
can be used to select the cert filecaching fetched certs
allow the user to cache fetched certs to disk
so for example, when fetching the cert from
http://secure.globalsign.com/cacert/gsgccr6alphasslca2023.crt
then store the cert in
/tmp/aia-certs/secure.globalsign.com/cacert/gsgccr6alphasslca2023.crt
this is useful to address the privacy concerns with AIA
todo: fetch all certs from server
currently we fetch only the first cert = leaf cert
ss.getpeercert(True)
to fetch all certs:
see also Getting certificate chain with Python 3.3 SSL module
for example,
www.google.com:443
returns 3 certscert 2 is signed by
GlobalSign Root CA
which is in the defaultca-bundle.crt
so the full chain is valid, and there is no need to fetch certs
to compare:
www788.ucdn.to:183
returns 2 certsbut for cert 0, the issuer
GlobalSign GCC R6 AlphaSSL CA
is missingso this cert must be fetched from
http://secure.globalsign.com/cacert/gsgccr6alphasslca2023.crt
... which is issued by
CN = GlobalSign
which is in the defaultca-bundle.crt