rabbitmq try/catch on close #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch (pun intended). Thank you, @featheredtoast |
featheredtoast
added a commit
to featheredtoast/wongchat
that referenced
this pull request
Feb 17, 2017
Patch for upstream issue: danielsz/system#105
|
FYI, deployed in |
|
Awesome, thanks so much! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm reloading a system that had a compiling error, I'm unable to restart the system due to already closed exceptions from rabbitmq. Handling already closed exceptions allows a system to recover more gracefully.