Fixed args for start() call on restart(). #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroseman
added a commit
that referenced
this pull request
Jan 2, 2014
Fixed args for start() call on restart().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to restart a daemon that's already stopped, the start call raises the following exception:
Traceback (most recent call last):
File "manage.py", line 14, in
execute_manager(settings)
File "/usr/lib/python2.6/site-packages/django/core/management/init.py", line 459, in execute_manager
utility.execute()
File "/usr/lib/python2.6/site-packages/django/core/management/init.py", line 382, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 196, in run_from_argv
self.execute(_args, *_options.dict)
File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 232, in execute
output = self.handle(_args, *_options)
File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 371, in handle
return self.handle_noargs(**options)
File "/usr/lib/python2.6/site-packages/django_initd-0.0.1-py2.6.egg/daemon_command.py", line 64, in handle_noargs
daemon.execute(action, run=self.loop_callback, exit=self.exit_callback)
File "/usr/lib/python2.6/site-packages/django_initd-0.0.1-py2.6.egg/initd.py", line 131, in execute
cmd(run, exit)
File "/usr/lib/python2.6/site-packages/django_initd-0.0.1-py2.6.egg/initd.py", line 126, in restart
self.start(run, self.pid_file, self.log_file)
TypeError: start() takes at most 3 arguments (4 given)
Which is fixed by this commit. Thanks for such a helpful package :)