chore(deps): update test packages #290

renovate · 2023-08-02T08:30:22Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@vitest/coverage-v8 (source)	`0.33.0` -> `0.34.1`
@vitest/ui (source)	`^0.33.0` -> `^0.34.0`
happy-dom	`10.5.2` -> `10.8.0`
vitest	`0.33.0` -> `0.34.1`
vitest	`^0.24.5 \|\| ^0.26.0 \|\| ^0.27.0 \|\| ^0.28.0 \|\| ^0.29.0 \|\| ^0.30.0 \|\| ^0.33.0` -> `^0.24.5 \|\| ^0.26.0 \|\| ^0.27.0 \|\| ^0.28.0 \|\| ^0.29.0 \|\| ^0.30.0 \|\| ^0.33.0 \|\| ^0.34.0`

Release Notes

vitest-dev/vitest (@vitest/coverage-v8)

`v0.34.1`

Compare Source

🐞 Bug Fixes

Pass --experimental-vm-worker-memory-limit to tinypool - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3856 (3c67a)

View changes on GitHub

`v0.34.0`

Compare Source

🚨 Breaking Changes

Transform mode affects only test files, not regular files - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3491 (9608b)
- transformMode is now moved to server.transformMode. This option is highly discouraged to use. If you need to change the transform mode, use the new option testTransformMode instead to control the mode based on the running test, not the current file path. By default, tests with jsdom or happy-dom use web transform mode, and tests using node or edge environment use ssr mode. If you have a custom environment, it should provide transformMode property.
Disable coverage.reportOnFailure by default - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3615 (0c6f6)
Remove @vitest/coverage-c8 package - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3614 (a90d6)
- @vitest/coverage-c8 is no longer supported. Please, use @vitest/coverage-v8 instead.
Support running tests using VM context - by @sheremet-va and @dammy001 in https://github.com/vitest-dev/vitest/issues/3203 (b0929)
- To address speed issues in some applications, Vitest now provides experimentalVmThreads pool to run your tests using VM Sandboxes environment. Make sure you understand all pitfalls of this pool before opening an issue.
Introduce server option - by @fenghan34 and @sheremet-va in https://github.com/vitest-dev/vitest/issues/3725 (dc4fa)
- Most of deps. options are now moved to server.deps with a deprecation warning. Please, consider using deps.optimizer instead of deps.inline/deps.external. Ideally, we would like to move away from using server.deps.inline altogether.
vite-node: Make CLI arguments parsing behavior consistent with node/tsx/ts-node - by @rxliuli in https://github.com/vitest-dev/vitest/issues/3574 (1cd4e)
- You now have to provide CLI arguments before the entry point. For example, instead of vite-node index.ts --watch, you now have to do vite-node --watch index.ts.
Add preact example, remove optimizer experimental status, enable by default - by @sheremet-va and @eryue0220 in https://github.com/vitest-dev/vitest/issues/3854 (4b946)
- deps.optimizer is now enabled by default. This means that Vitest will bundle specified dependencies before running your tests. This field inherits options from optimizeDeps and ssr.optimizeDeps which are populated by other plugins (like, Svelte).

🚀 Features

Support describe.sequential - by @fenghan34 and @dammy001 in https://github.com/vitest-dev/vitest/issues/3771 (86934)
Support config junit reporter className with env - by @InfiniteXyy in https://github.com/vitest-dev/vitest/issues/3808 (e8bc4)
Running vitest with --related --watch reruns non-affected tests if they were changed during a run - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3844 (c9aea)

🐞 Bug Fixes

Isolate workers between envs and workspaces - by @AriPerkkio (ed4e0)
Modify condition - by @btea (a78e6)
Module Graph view is blocking the Console view - by @g4rry420 (3b5f9)
Port the latest defineConfig type from vite - by @sodatea in https://github.com/vitest-dev/vitest/issues/3804 (9c8e3)
Don't overwrite Node.js URL global - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3828 (cdab4)
ForceRerunTriggers correctly triggers a rerun - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3829 (17988)
browser:
- Don't inline magic-string and estree-walker - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3726 (ee937)
- Multi-suite coverage - by @elby22 in https://github.com/vitest-dev/vitest/issues/3806 (5de9a)
core:
- DataView comparison does not work in toStrictEqual - by @Dunqing (52aef)
coverage:
- V8 provider to pick source maps without url query params - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3784 (280e6)
- Update istanbul-lib-instrument to v6 to fix vulnerable dependency - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3814 (f3bd9)
- Exclude vite virtual modules by default - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3794 (3c851)
node:
- Guard error info - by @btea (88b39)
vite-node:
- Always treat node_modules as modulesDirectory - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3830 (51ab8)
- Normalize drive letter to keep the same reference to a module - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3836 (45521)
- Correctly resolve hmr filepath - by @sheremet-va in https://github.com/vitest-dev/vitest/issues/3834 (711a6)
watch:
- Clear screen on all terminals - by @AriPerkkio in https://github.com/vitest-dev/vitest/issues/3661 (8bd26)

🏎 Performance

Deprecate deps.registerNodeLoader - by @sheremet-va (7f45b)
- This option was introduced to support aliasing inside external packages. Please, use deps.optimizer.web instead. If you test Node.js applications, consider adding external packages to server.deps.inline.

View changes on GitHub

capricorn86/happy-dom (happy-dom)

`v10.8.0`

Compare Source

👷‍♂️ Patch fixes

Fixes bug related to item being null in HTMLButtonElement.attributes.removeNamedItem(). (#1010)

Thank you @maxmilton for your contribution!

`v10.7.0`

Compare Source

🎨 Features

Add support for Element.scrollHeight. The property will just return "0" for now. (#991)

Thank you @lukaselmer for your contribution!

`v10.6.3`

Compare Source

👷‍♂️ Patch fixes

Adds missing named CSS colors to CSSStyleDeclaration. (#1004)

Thank you @AlexisTessier for your contribution!

`v10.6.2`

Compare Source

`v10.6.1`

Compare Source

👷‍♂️ Patch fixes

Fixes issue where only labels associated using ID where found in HTMLButtonElement.labels, HTMLInputElement.labels, HTMLSelectElement.labels and HTMLTextAreaElement.labels. It will now also return labels associated by being a parent. (#988)

Thank you @joshkel for your contribution!

`v10.6.0`

Compare Source

🎨 Features

Improves support for support for HTMLLabelElement.control. It will now find child control elements that are deeper than one level. (#530)

Thank you @joshkel for your contribution!

`v10.5.3`

Compare Source

👷‍♂️ Patch fixes

Improves support for NamedNodeMap, which is used by the Element.attributes property. It will now reflect any changes done to it on the Element itself. (#728)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

socket-security · 2023-08-02T08:31:32Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
vitest	0.33.0...0.34.6	environment	`+8/-8`	24.8 MB	oreanno
vite	4.4.11...4.4.9	None	`+1/-1`	5.85 MB	vitebot

renovate · 2023-08-07T14:59:58Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

danielroe · 2023-08-14T16:33:23Z

@sheremet-va Do you have any idea how we can get the vitest-environment-nuxt package to be inlined as previously? We need to because it uses an import alias #app/entry in its environment setup function to import a path alias that is defined in the vitest config it gets from nuxt.

sheremet-va · 2023-08-14T16:41:15Z

@sheremet-va Do you have any idea how we can get the vitest-environment-nuxt package to be inlined as previously? We need to because it uses an import alias #app/entry in its environment setup function to import a path alias that is defined in the vitest config it gets from nuxt.

deps.inline is just moved to server.deps.inline, and it will not be removed on release.

danielroe · 2023-08-14T20:05:56Z

Strangely, even though we've made that change in this PR, it still fails to run. (In other words, it's not behaving the same as deps.inline did before.)

sheremet-va · 2023-08-14T20:29:20Z

Strangely, even though we've made that change in this PR, it still fails to run. (In other words, it's not behaving the same as deps.inline did before.)

What I'm seeing in the PR is that Vite resolves vitest-environment-nuxt to require condition. Why it does this I'm not sure (because no ssr flag anymore?). inline never affected how imports are resolved.

Anyway, publishing CJS entry seems pointless when you import from vitest since we don't provide any CJS support for the public API.

danielroe · 2023-08-14T21:28:08Z

Checking when removing CJS builds, the issue is that local-pkg does not have support for pure ESM packages and uses CJS resolution strategy.

But even when patching vitest, it doesn't solve the issue. We still end up with the following error:

TypeError: Package import specifier "#app/entry" is not defined in package /Users/daniel/code/vitest-environment-nuxt/packages/vitest-environment-nuxt/package.json imported from /Users/daniel/code/vitest-environment-nuxt/packages/vitest-environment-nuxt/dist/index.mjs
 ❯ new NodeError node:internal/errors:387:5
 ❯ throwImportNotDefined node:internal/modules/esm/resolve:354:9
 ❯ packageImportsResolve node:internal/modules/esm/resolve:737:3
 ❯ moduleResolve node:internal/modules/esm/resolve:895:21
 ❯ defaultResolve node:internal/modules/esm/resolve:1115:11
 ❯ nextResolve node:internal/modules/esm/loader:163:28
 ❯ ESMLoader.resolve node:internal/modules/esm/loader:841:30
 ❯ ESMLoader.getModuleJob node:internal/modules/esm/loader:424:18
 ❯ ESMLoader.import node:internal/modules/esm/loader:525:22
 ❯ importModuleDynamically node:internal/modules/esm/translators:110:35

Note that this is a regression in this version of vitest - it's not replicable with the exact same code in 0.33.

sheremet-va · 2023-09-22T10:14:41Z

An update to environments is released in 0.34.4

danielroe · 2023-09-23T11:25:18Z

@sheremet-va We now have a new issue with vite-node - it looks at first glance like an issue with mocking CJS utils.

Run logs

⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯
Error: Cannot find module './browser.js'
Require stack:
- /home/runner/work/nuxt-vitest/nuxt-vitest/playground/debug
 ❯ Module._resolveFilename node:internal/modules/cjs/loader:1077:15
 ❯ Module._load node:internal/modules/cjs/loader:922:27
 ❯ Module.require node:internal/modules/cjs/loader:1143:19
 ❯ require node:internal/modules/cjs/helpers:121:18
 ❯ debug:7:19
 ❯ ViteNodeRunner.runModule ../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite-node/dist/client.mjs:342:11
 ❯ ViteNodeRunner.directRequest ../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite-node/dist/client.mjs:326:16
 ❯ ViteNodeRunner.cachedRequest ../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite-node/dist/client.mjs:189:14
 ❯ ViteNodeRunner.dependencyRequest ../node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite-node/dist/client.mjs:223:12
 ❯ async /home/runner/work/nuxt-vitest/nuxt-vitest/playground/vite-node/client:6:31

Checking the vite node context, we have this:

{
    __filename: '/Users/daniel/code/nuxt-vitest/playground/debug',
    __dirname: '/Users/daniel/code/nuxt-vitest/playground'
}

These seem like the wrong results for the transform request, but I could be wrong.

sheremet-va · 2023-09-28T12:44:34Z

Should be fixed by: vitest-dev/vitest#4196

I am a bit surprised it works like this, looks like a potential performance optimization.

danielroe · 2023-09-28T13:52:28Z

@sheremet-va I really appreciate all your help on this ❤️

sheremet-va · 2023-09-29T08:35:06Z

Fix is released in 0.34.6

antfu · 2023-10-03T02:45:29Z

The error now is caused by multiple instances of Vue. Tried with VITE_NODE_DEBUG_DUMP=1

In nuxt/dist/app/entry.js is importing vue and nuxt/dist/app/nuxt.js, while nuxt/dist/app/nuxt.js is importing /node_modules/.vitest/deps/vue.js?v=2c47765e.

I am able to fix most of the tests with (still some failing with other errors):

test: {
    deps: {
      optimizer: {
        web: {
          enabled: false
        }
      }
    },
}

I am a bit rusted with Vitest, I guess @sheremet-va might have a better context?

antfu · 2023-10-03T03:11:56Z

I also found that, in defineVitestConfig we use mergeConfig from Vite, which does not merge but overrides the test object. Meaning that if a user provides a custom test option, the entire default config from Nuxt will be ignored. Fixed

sheremet-va · 2023-10-03T07:17:42Z

I am a bit rusted with Vitest, I guess @sheremet-va might have a better context?

Even though the environment file is loaded in the same scope as your tests, it is now always processed with ssr flag which means it can resolve to a different file (so, environment imports vue from vue and tests import vue from .deps/vue). This is probably the cause of the issues here.

I would recommend rewriting the environment to be environment agnostic (don't rely on imports because they are environment-specific), to be honest. To support VM (which is faster and might be the direction Vitest takes in the future), you would need to rewrite it with a similar notion in mind.

oskarols · 2023-11-15T17:11:50Z

@danielroe @antfu It's a bit hard to grasp the scope of changes necessary here, is there anything we could do to help this along? 😄

renovate bot added chore dependencies labels Aug 2, 2023

renovate bot changed the title ~~chore(deps): update test packages to v0.34.1~~ chore(deps): update test packages Aug 2, 2023

renovate bot force-pushed the renovate/test-packages branch 7 times, most recently from 36805e9 to d8ff8a0 Compare August 4, 2023 01:46

oskarols mentioned this pull request Aug 4, 2023

Package subpath './environments' is not defined by "exports" nuxt/test-utils#509

Closed

renovate bot force-pushed the renovate/test-packages branch 10 times, most recently from 58b046d to a489652 Compare August 7, 2023 13:25

danielroe force-pushed the renovate/test-packages branch from 80eb116 to 13ea9b3 Compare August 14, 2023 16:34

danielroe mentioned this pull request Aug 14, 2023

fix(vitest): use esm module resolution to resolve env vitest-dev/vitest#3951

Merged

6 tasks

fix: add regexps to match monorepo packages

b921a04

chore: bump again

175d23b

danielroe force-pushed the renovate/test-packages branch from a3fdfcc to 175d23b Compare September 23, 2023 11:13

Merge remote-tracking branch 'origin/main' into renovate/test-packages

648f061

sheremet-va mentioned this pull request Sep 28, 2023

fix: correctly resolve external dependencies loaded by custom environments vitest-dev/vitest#4196

Merged

6 tasks

danielroe added 5 commits September 29, 2023 10:39

chore: bump vitest versions

d2971c5

Merge remote-tracking branch 'origin/main' into renovate/test-packages

0cd2cd2

chore: revert some pr-specific changes

4145299

Merge remote-tracking branch 'origin/main' into renovate/test-packages

95e6b66

Merge remote-tracking branch 'origin/main' into renovate/test-packages

d7b4f8d

antfu added 2 commits October 3, 2023 10:50

chore: add workaround

4d6040b

fix: handle defineVitestConfig merging

c8444a5

danielroe added 3 commits October 3, 2023 08:28

chore: bump peer deps

8a1b510

Merge remote-tracking branch 'origin/main' into renovate/test-packages

3dbfce7

Merge remote-tracking branch 'origin/main' into renovate/test-packages

3072dc4

This was referenced Nov 20, 2023

fix(nuxt): respect custom timeout in useFetch nuxt/nuxt#24364

Merged

chore: update vitest to 0.34.6 nuxt/test-utils#248

Merged

danielroe mentioned this pull request Dec 1, 2023

fix!: load nuxt app within setupFiles nuxt/test-utils#260

Merged

danielroe added the nuxt-vitest label Dec 2, 2023

danielroe closed this Dec 19, 2023

danielroe deleted the renovate/test-packages branch December 19, 2023 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update test packages #290

chore(deps): update test packages #290

renovate bot commented Aug 2, 2023 •

edited

Loading

socket-security bot commented Aug 2, 2023 •

edited

Loading

renovate bot commented Aug 7, 2023

danielroe commented Aug 14, 2023

sheremet-va commented Aug 14, 2023

danielroe commented Aug 14, 2023 •

edited

Loading

sheremet-va commented Aug 14, 2023 •

edited

Loading

danielroe commented Aug 14, 2023

sheremet-va commented Sep 22, 2023

danielroe commented Sep 23, 2023

sheremet-va commented Sep 28, 2023 •

edited

Loading

danielroe commented Sep 28, 2023

sheremet-va commented Sep 29, 2023

antfu commented Oct 3, 2023

antfu commented Oct 3, 2023

sheremet-va commented Oct 3, 2023 •

edited

Loading

oskarols commented Nov 15, 2023

chore(deps): update test packages #290

chore(deps): update test packages #290

Conversation

renovate bot commented Aug 2, 2023 • edited Loading

Release Notes

🐞 Bug Fixes

🚨 Breaking Changes

🚀 Features

🐞 Bug Fixes

🏎 Performance

👷‍♂️ Patch fixes

🎨 Features

👷‍♂️ Patch fixes

👷‍♂️ Patch fixes

🎨 Features

👷‍♂️ Patch fixes

Configuration

socket-security bot commented Aug 2, 2023 • edited Loading

renovate bot commented Aug 7, 2023

Edited/Blocked Notification

danielroe commented Aug 14, 2023

sheremet-va commented Aug 14, 2023

danielroe commented Aug 14, 2023 • edited Loading

sheremet-va commented Aug 14, 2023 • edited Loading

danielroe commented Aug 14, 2023

sheremet-va commented Sep 22, 2023

danielroe commented Sep 23, 2023

sheremet-va commented Sep 28, 2023 • edited Loading

danielroe commented Sep 28, 2023

sheremet-va commented Sep 29, 2023

antfu commented Oct 3, 2023

antfu commented Oct 3, 2023

sheremet-va commented Oct 3, 2023 • edited Loading

oskarols commented Nov 15, 2023

renovate bot commented Aug 2, 2023 •

edited

Loading

socket-security bot commented Aug 2, 2023 •

edited

Loading

danielroe commented Aug 14, 2023 •

edited

Loading

sheremet-va commented Aug 14, 2023 •

edited

Loading

sheremet-va commented Sep 28, 2023 •

edited

Loading

sheremet-va commented Oct 3, 2023 •

edited

Loading