Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with unconfirmed list of channels #24

Open
mbutan opened this issue Jan 27, 2017 · 1 comment
Open

Problem with unconfirmed list of channels #24

mbutan opened this issue Jan 27, 2017 · 1 comment

Comments

@mbutan
Copy link

mbutan commented Jan 27, 2017

Hey,

the problem is related to unsubscribed channels which from some server or others reasons couldn't be subscribed (without any confirmation). If the channel's event ChannelEventsChannel appends unconfirmedChannels list cannot be released properly and is returning all the time. I suggest to release this array when unsubscribe() is called.

mbutan added a commit to mbutan/Swift-ActionCableClient that referenced this issue Jan 27, 2017
@danipralea
Copy link
Contributor

danipralea commented Feb 3, 2017

I think the issue resides in channels being identified by their name property.
Another solution I would see is either specify the identifier to the Channel in the channels property of the ActionCableClient, or do the identification by default on its identifier dictionary passed at the create: function.
Either way, they don't need to be identified or have only the current option of being identified by their name property. Cause on the server you connect to the same class name, so all channels will have the same name.
I'm not sure if I made myself clear, @danielrhodes. If I didn't, I can further develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants