This repository has been archived by the owner on Feb 4, 2024. It is now read-only.
adding PRESS events support for HmIP-BSM #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as EVENTNODE for channel 4 does not make sense for the HmIP-BSM
pyhomematic/devicetypes/actors.py
Outdated
| def __init__(self, device_description, proxy, resolveparamsets=False): | ||
| super().__init__(device_description, proxy, resolveparamsets) | ||
|
|
||
| self.ELEMENT.extend([1, 2]) |
There was a problem hiding this comment.
I think you can leave away the ELEMENT since you are setting channels 1 and 2 explicitly in the EVENTNODE. Could you please try if it works without this line?
There was a problem hiding this comment.
Appears to work without explicitly extending ELEMENT. Pull request updated accordingly!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.