Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]Image / Instruction panel #327

Closed
yinlokc opened this issue Sep 25, 2024 · 6 comments
Closed

[Feature request]Image / Instruction panel #327

yinlokc opened this issue Sep 25, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request form-runtime

Comments

@yinlokc
Copy link

yinlokc commented Sep 25, 2024

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
I would like to follow up on #124 and #164 and have image supported in Document Block on the form.
Additional context

@yinlokc yinlokc added the enhancement New feature or request label Sep 25, 2024
@danielo515
Copy link
Owner

How would you like to have it? Just like using markdown or with an image tag? <img src='something'/>

@yinlokc
Copy link
Author

yinlokc commented Sep 26, 2024

markdown will be better if possible, as I found there is quite a lot of discussion around html image tag which is not straightforward to retrieve the image source. Thanks for considering the suggestion.

@danielo515
Copy link
Owner

danielo515 commented Sep 27, 2024 via email

danielo515 added a commit that referenced this issue Sep 29, 2024
fixes [Feature request]Image / Instruction panel  #327
@danielo515
Copy link
Owner

I finally decided to take a slightly different route and, instead of adding support for images to the existing document block, which will be probably hard (specially if you want markdown syntax).
Instead, I created a new "presentation" block, that I called markdown block. It is the same as document block but with markdown syntax. I also updated both to have access to dataview API, so both now should be much more powerful.
The markdown one, in my testing, supports images.
Take a look at the release notes:
https://danielorodriguez.com/obsidian-modal-form/blog/2024/09/29/release-notes-for-1520/

@yinlokc
Copy link
Author

yinlokc commented Sep 29, 2024

It is brillant, thanks for your swift response and release.

@danielo515
Copy link
Owner

Thanks for the positive feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request form-runtime
Projects
None yet
Development

No branches or pull requests

2 participants