Turn StackTraceHandler into a static class

x-pack/plugin/profiling/src/main/java/org/elasticsearch/xpack/profiling/TransportGetStackTracesAction.java

@@ -63,6 +63,7 @@
 import java.util.concurrent.ConcurrentSkipListSet;
 import java.util.concurrent.Executor;
 import java.util.concurrent.atomic.AtomicInteger;
+import java.util.function.BiConsumer;
 import java.util.function.Function;
 
 public class TransportGetStackTracesAction extends TransportAction<GetStackTracesRequest, GetStackTracesResponse> {
@@ -423,15 +424,13 @@ private void retrieveStackTraces(
         }
 
         StackTraceHandler handler = new StackTraceHandler(
-            submitTask,
-            clusterState,
-            client,
             responseBuilder,
             submitListener,
             eventIds.size(),
             // We need to expect a set of slices for each resolved index, plus one for the host metadata.
             slicedEventIds.size() * indices.size() + (uniqueHostIDs.isEmpty() ? 0 : 1),
-            uniqueHostIDs.size()
+            uniqueHostIDs.size(),
+                (s, e) -> retrieveStackTraceDetails(submitTask, clusterState, client, responseBuilder, s, e, submitListener)
         );
         for (List<String> slice : slicedEventIds) {
             mget(client, indices, slice, ActionListener.wrap(handler::onStackTraceResponse, submitListener::onFailure));
@@ -481,12 +480,9 @@ static <T> List<List<T>> sliced(List<T> c, int slices) {
         return Collections.unmodifiableList(slicedList);
     }
 
-    private class StackTraceHandler {
+    private static final class StackTraceHandler {
         private final AtomicInteger expectedResponses;
         private final int initialExpectedResponses;
-        private final Task submitTask;
-        private final ClusterState clusterState;
-        private final Client client;
         private final GetStackTracesResponseBuilder responseBuilder;
         private final ActionListener<GetStackTracesResponse> submitListener;
         private final Map<String, StackTrace> stackTracePerId;
@@ -500,25 +496,23 @@ private class StackTraceHandler {
         private final StopWatch hostsWatch = new StopWatch("retrieveHostMetadata");
         private final Map<String, HostMetadata> hostMetadata;
 
+        private final BiConsumer<List<String>, List<String>> detailsHandler;
+
         private StackTraceHandler(
-            Task submitTask,
-            ClusterState clusterState,
-            Client client,
             GetStackTracesResponseBuilder responseBuilder,
             ActionListener<GetStackTracesResponse> submitListener,
             int stackTraceCount,
             int expectedResponses,
-            int expectedHosts
+            int expectedHosts,
+            BiConsumer<List<String>, List<String>> detailsHandler
         ) {
-            this.submitTask = submitTask;
-            this.clusterState = clusterState;
             this.stackTracePerId = new ConcurrentHashMap<>(stackTraceCount);
             this.initialExpectedResponses = expectedResponses;
             this.expectedResponses = new AtomicInteger(expectedResponses);
-            this.client = client;
             this.responseBuilder = responseBuilder;
             this.submitListener = submitListener;
             this.hostMetadata = new HashMap<>(expectedHosts);
+            this.detailsHandler = detailsHandler;
         }
 
         public void onStackTraceResponse(MultiGetResponse multiGetItemResponses) {
@@ -540,7 +534,7 @@ public void onStackTraceResponse(MultiGetResponse multiGetItemResponses) {
                         if (stackTracePerId.putIfAbsent(id, stacktrace) == null) {
                             totalFrames.addAndGet(stacktrace.frameIds.size());
                             stackFrameIds.addAll(stacktrace.frameIds);
-                            stacktrace.forNativeAndKernelFrames(e -> executableIds.add(e));
+                            stacktrace.forNativeAndKernelFrames(executableIds::add);
                         }
                     }
                 }
@@ -621,7 +615,10 @@ public void mayFinish() {
                 TraceLogger.stop(null, "process stacktrace response finish");
                 TraceLogger.stop(null, "process stacktrace response");
                 TraceLogger.stop(null, "retrieveStackTraces");
-                retrieveStackTraceDetails(
+                detailsHandler.accept(new ArrayList<>(stackFrameIds),new ArrayList<>(executableIds));
+                /*
+                retrieveStackTraceDetails(new ArrayList<>(stackFrameIds),
+                    new ArrayList<>(executableIds));
                     submitTask,
                     clusterState,
                     client,
@@ -630,6 +627,7 @@ public void mayFinish() {
                     new ArrayList<>(executableIds),
                     submitListener
                 );
+                 */
             }
         }
     }