crypto: check return code from EVP_DigestUpdate

Coverity was complaining that we did not check the return code. We seem to check in the other place it is called and the method already handles returning a result. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41800 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
danielleadams · Mar 4, 2022 · 5497454 · 5497454
1 parent 493fc61
commit 5497454
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/crypto/crypto_hash.cc b/src/crypto/crypto_hash.cc
@@ -122,8 +122,7 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) {
 bool Hash::HashUpdate(const char* data, size_t len) {
   if (!mdctx_)
     return false;
-  EVP_DigestUpdate(mdctx_.get(), data, len);
-  return true;
+  return EVP_DigestUpdate(mdctx_.get(), data, len) == 1;
 }
 
 void Hash::HashUpdate(const FunctionCallbackInfo<Value>& args) {