only record explicit params (don't default to 0) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change, a sequence like \e[C will be interpreted as \e[0C, which is incorrect. we need to keep track of whether a param was actually passed so that each individual sequence can determine its own default (m = 0, C = 1, etc) Signed-off-by: Alex Suraci <[email protected]>
vito
force-pushed
the
fix-param-defaults
branch
from
bf7b7db
to
bcd631b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, a sequence like
\e[Cwill be interpreted as\e[0C, which is incorrect. We need to keep track of whether a param was actually passed so that each individual sequence can determine its own default withGetOrDefault(m= 0,C= 1, etc).