fix tests

danielgafni · Oct 7, 2024 · d570178 · d570178
1 parent 1f7afb2
commit d570178
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -50,9 +50,10 @@ jobs:
         with:
           start: false
           driver: docker
+          #- uses: mxschmitt/action-tmate@v3
       - name: Run tests
         env:
-          PYTEST_KUBERAY_VERSIONS: "1.0.0,1.1.0"  # will run tests for all these KubeRay versions
+          PYTEST_KUBERAY_VERSIONS: "1.1.0,1.2.2"  # will run tests for all these KubeRay versions
         run: uv run pytest -v .
 
   lint:
@@ -64,7 +65,6 @@ jobs:
         os:
           - Ubuntu
         py:
-#          - "3.12"
           - "3.11"
           - "3.10"
           - "3.9"

diff --git a/dagster_ray/kuberay/client/raycluster/client.py b/dagster_ray/kuberay/client/raycluster/client.py
@@ -141,6 +141,8 @@ def wait_until_ready(
                 and item["metadata"].get("name") == name  # type: ignore
                 and status.get("state") == "ready"
                 and status.get("head")
+                and status.get("head", {}).get("serviceName")
+                and status.get("endpoints", {}).get("dashboard")
             ):
                 if image is not None:
                     if (

diff --git a/tests/kuberay/conftest.py b/tests/kuberay/conftest.py
@@ -70,7 +70,7 @@ def dagster_ray_image():
 # probably should only do it in CI
 KUBERNETES_VERSION = os.getenv("PYTEST_KUBERNETES_VERSION", "1.31.0")
 
-KUBERAY_VERSIONS = os.getenv("PYTEST_KUBERAY_VERSIONS", "1.2.0").split(",")
+KUBERAY_VERSIONS = os.getenv("PYTEST_KUBERAY_VERSIONS", "1.2.2").split(",")
 
 NAMESPACE = "ray"