Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stdlib CSV options to be passed through #4

Merged
merged 6 commits into from
Mar 20, 2015

Conversation

ibroadfo
Copy link
Contributor

No description provided.

@danielfone
Copy link
Owner

@ibroadfo Thanks! I like this. Good thinking keeping the stdlib options in a self-contained key. If you've got some time to fix the rails test suite, please do so. I don't imagine it's too hard. Otherwise I'll fix that up and merge as soon as I get a chance.

@ibroadfo
Copy link
Contributor Author

So the build is passing, but not sure whether we want the rails 4.2 changes
to happen on this PR?
On Thu, 19 Mar 2015 at 21:29, Daniel Fone [email protected] wrote:

@ibroadfo https://github.com/ibroadfo Thanks! I like this. Good
thinking keeping the stdlib options in a self-contained key. If you've got
some time to fix the rails test suite, please do so. I don't imagine it's
too hard. Otherwise I'll fix that up and merge as soon as I get a chance.

Reply to this email directly or view it on GitHub
#4 (comment).

danielfone added a commit that referenced this pull request Mar 20, 2015
Allow stdlib CSV options to be passed through
@danielfone danielfone merged commit bcc2766 into danielfone:master Mar 20, 2015
@danielfone
Copy link
Owner

Yeah, lgtm. I'll push a new version of the gem.

@ibroadfo
Copy link
Contributor Author

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants