Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Build issues with Xcode 10.1 and swift 4.2 #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Foo/Foo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
Expand Down Expand Up @@ -351,6 +352,7 @@
IPHONEOS_DEPLOYMENT_TARGET = 8.2;
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = "1,2";
VALIDATE_PRODUCT = YES;
VERSIONING_SYSTEM = "apple-generic";
Expand Down
14 changes: 6 additions & 8 deletions Foo/Foo/Bar.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,21 @@
//

import UIKit
import FooPrivate
import Foo_Private



@objc(Bar)
public class Bar: NSObject {
@objc public class Bar: NSObject {

public func doSomething() {
@objc public func doSomething() {
// We can access Baz, which is public:
let b = Baz()
println("\(b)")
print("\(b)")

// We can also access Norf, even though it is not public:
let n = Norf()
println("\(n)")
print("\(n)")

let q = Qux()
println("\(q)")
print("\(q)")
}
}
2 changes: 1 addition & 1 deletion Foo/Foo/Foo.private.modulemap
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module FooPrivate {
module Foo_Private {
export *
}
2 changes: 1 addition & 1 deletion Foo/Foo/FooPrivate/module.modulemap
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

This file lives inside a folder, and that folder is the actual module. In Xcode the SWIFT_INCLUDE_PATHS needs to include the partent directory to that folder.
*/
module FooPrivate {
module Foo_Private {
header "../Norf.h"
export *
}
2 changes: 1 addition & 1 deletion Foo/FooTests/FooTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class FooTests: XCTestCase {

func testPerformanceExample() {
// This is an example of a performance test case.
self.measureBlock() {
self.measure() {
// Put the code you want to measure the time of here.
}
}
Expand Down
2 changes: 0 additions & 2 deletions MyApp/ViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
import UIKit
import Foo



class ViewController: UIViewController {

override func viewDidLoad() {
Expand Down