-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The release version does not contain some fixes #314
Comments
Hi @NoMercy235, maybe you're running against a cached version in your |
Hey Daniel! I have just recently started using react-d3-graph, so I'm pretty sure there are no cache issues involved and that the installed version is indeed |
As stated in the #312 ticket, the update to v2.4.1 brought all the changes. Thanks! |
Describe the bug
The version you are currently downloading when installing from the npm does not contain some fixes. In particular, I was looking for this (found in the release logs of v2.4.0:
Others, too, may be missing.
To Reproduce
Steps to reproduce the behavior:
type
s for the input links.Expected behavior
The links with the custom type should look accordingly
Screenshots
These two-way links should have their custom type set to
CURVED_SMOOTH
, but they still show up asSTRAIGHT
Environment:
react-d4-version: 2.4.0
Additional context
I believe that the
npm run dist
script was not launched. I have cloned the repo locally, ran the script, and thelib/components/graph/graph.builder.js
has a different output than what comes when installing via npm. In particular, there is thebuildLinkProps
function which is missing this line:(and then the following usages of
type
)The text was updated successfully, but these errors were encountered: