Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link.type only can make effect in global #234

Closed
anewcoder1992 opened this issue Sep 26, 2019 · 3 comments
Closed

link.type only can make effect in global #234

anewcoder1992 opened this issue Sep 26, 2019 · 3 comments

Comments

@anewcoder1992
Copy link

anewcoder1992 commented Sep 26, 2019

Is your feature request related to a problem? Please describe.
I have test link.type can only make effect when set in the config. You can not specified one type for a link.

  const myConfig = {
    node: {
      size: 600,
      fontSize:18,
      fontWeight:'bold',
      labelProperty:'name',
    },
    link: {
      type:'CURVE_SMOOTH',
      labelProperty: 'leadtime',
    }
  }

Describe the solution you'd like
when i set one link

    links: [
      { source: 'b1', target: 'c2', leadtime: '24 days' , type:'CURVE_SMOOTH',},
      { source: 'c1', target: 'd1', leadtime: 'check',type:'STRAIGHT' },
    ]

it did not not make effect.
i think the (link.type) should as same as( node.svg)that can specified one svg for a node.

@danielcaldas
Copy link
Owner

Hello, @MoonSeeing thanks for reporting it. This library is slowly moving into having all its properties to take local and global effect. We can see for past requests such as:

So I recognize that this request makes sense and it's not actually much work to implement, feel free to submit a Pull Request. If I may add, you can even submit the PR next week for Hacktoberfest 😉

@gopherine
Copy link
Contributor

gopherine commented Oct 13, 2019

@danielcaldas I have made a pull request however i dont like the way i have named the variable may be someone can guide me on this i need it so i ll do it quickly hoping for quick update using this to show hybrid network ... where i need to show local and global edges distinctively so yes also this is my first time contributing to open source so please let me know if i did something wrong thanks :)

@danielcaldas
Copy link
Owner

Done with #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants