Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project dependency #52

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Add project dependency #52

merged 1 commit into from
Sep 21, 2024

Conversation

daniel-mizsak
Copy link
Owner

  • Linting passes
  • Tests are added and passing
  • Documentation is updated

The reason for the added seemingly unnecessary dependency is to showcase that dependency versions for packages should not (or minimally) be restricted in the pyproject.toml file so that packages depending on it have an easier time solving versioning conflicts.

Instead, the good old requirements.txt can be used to exactly reproduce a working state of the solution if it is about to be deployed.

Source:
https://stackoverflow.com/questions/74508024/is-requirements-txt-still-needed-when-using-pyproject-toml

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (574b801) to head (9223d5f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           36        37    +1     
=========================================
+ Hits            36        37    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-mizsak daniel-mizsak merged commit f5fedfd into main Sep 21, 2024
11 checks passed
@daniel-mizsak daniel-mizsak deleted the feature/add-dependency branch September 21, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant