Added trip service #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for this 🥳 I'll come back to you on Monday with a review 🤗
…On May 1, 2020 1:43:01 PM UTC, "H.M.S.Nishantha" ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#20
-- Commit Summary --
* Added trip service
-- File Changes --
M libosrmc/osrmc.cc (130)
M libosrmc/osrmc.h (21)
-- Patch Links --
https://github.com/daniel-j-h/libosrmc/pull/20.patch
https://github.com/daniel-j-h/libosrmc/pull/20.diff
|
daniel-j-h
reviewed
May 4, 2020
| } | ||
| } catch (const std::exception& e) { | ||
| osrmc_error_from_exception(e, error); | ||
| } |
There was a problem hiding this comment.
Why are these annotation features needed for the trip service?
If you want them in, can you split it at least into two commits please.
| auto* params_typed = reinterpret_cast<osrm::TripParameters*>(params); | ||
|
|
||
| if (first) | ||
| params_typed->source = osrm::TripParameters::SourceType::First; |
There was a problem hiding this comment.
We should support all enum values here; not sure a bool first is enough here.
| void osrmc_trip_params_add_destination(osrmc_trip_params_t params, bool last, osrmc_error_t* error) try { | ||
| auto* params_typed = reinterpret_cast<osrm::TripParameters*>(params); | ||
| if (last) | ||
| params_typed->destination = osrm::TripParameters::DestinationType::Last; |
|
Looks good overall; I left some smaller comments inline. General note: the trip service in osrm is pretty basic. We should probably add a note to the readme pointing the user e.g. to https://github.com/mapbox/node-or-tools which works on top of the distance table. |
|
@srimaln91 do you still want to run out the suggested changes and then bring it in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.