Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run websocket server on same port as other HTTP serving #685

Closed
khimaros opened this issue Oct 25, 2019 · 2 comments · Fixed by #3404
Closed

Run websocket server on same port as other HTTP serving #685

khimaros opened this issue Oct 25, 2019 · 2 comments · Fixed by #3404
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided Third party Needs an update from the third party library

Comments

@khimaros
Copy link

This is currently blocked on upstream Rocket feature which has seen some recent progress: rwf2/Rocket#90
@BlackDex
Copy link
Collaborator

I Think this is going to take a while when reading that ticket.
Luckily we can use reverse proxies to solve this shortcoming for now.

@BlackDex BlackDex added enhancement New feature or request Third party Needs an update from the third party library labels Oct 3, 2020
@BlackDex BlackDex added the low priority Won't fix anytime soon, but will accept PR if provided label Nov 18, 2020
@BlackDex
Copy link
Collaborator

Going to close this as an issue.
I have added it to the META Features request #246 .

Repository owner locked and limited conversation to collaborators Nov 14, 2022
@BlackDex BlackDex converted this issue into discussion #2917 Nov 14, 2022
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Apr 10, 2023
@BlackDex
WebSockets via Rocket's Upgrade connection
2382e12 
This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections.
No more need for multiple ports to be opened for Vaultwarden.
No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy).

- Using a git revision for Rocket, since `rocket_ws` is not yet released.
- Updated other crates as well.
- Added a connection guard to clear the WS connection from the Users list.

Fixes dani-garcia#685
Fixes dani-garcia#2917
Fixes dani-garcia#1424
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Apr 10, 2023
@BlackDex
WebSockets via Rocket's Upgrade connection
0cc9c48 
This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections.
No more need for multiple ports to be opened for Vaultwarden.
No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy).

- Using a git revision for Rocket, since `rocket_ws` is not yet released.
- Updated other crates as well.
- Added a connection guard to clear the WS connection from the Users list.

Fixes dani-garcia#685
Fixes dani-garcia#2917
Fixes dani-garcia#1424
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Apr 10, 2023
@BlackDex
WebSockets via Rocket's Upgrade connection
3d11f4c 
This PR implements a (not yet fully released) new feature of Rocket which allows WebSockets/Upgrade connections.
No more need for multiple ports to be opened for Vaultwarden.
No explicit need for a reverse proxy to get WebSockets to work (Although I still suggest to use a reverse proxy).

- Using a git revision for Rocket, since `rocket_ws` is not yet released.
- Updated other crates as well.
- Added a connection guard to clear the WS connection from the Users list.

Fixes dani-garcia#685
Fixes dani-garcia#2917
Fixes dani-garcia#1424

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided Third party Needs an update from the third party library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WebSockets via Rocket's Upgrade connection BlackDex/vaultwarden
2 participants
@khimaros @BlackDex